Comments on: You Probably Don’t Need ETag http://mrclay.org/index.php/2009/03/03/you-probably-dont-need-etag/ song for a future generation Thu, 26 Aug 2010 07:08:26 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: Steve http://mrclay.org/index.php/2009/03/03/you-probably-dont-need-etag/comment-page-1/#comment-102586 Steve Thu, 14 Jan 2010 14:09:40 +0000 http://mrclay.org/?p=274#comment-102586 What I haven't considered in this article is Content-Encoding. Of course individual clients will only receive one encoding version (gzip or identity), hence the 304 response is unambiguous, but can proxy caches store two differently-encoded resources from the same URL and serve them correctly based on Accept-Encoding from the client? I just want to try out mod_cache/squid before I remove ETags from Minify. I'd like to keep the CG class backward compatible. Minify::serve will pass in <code>'eTag' => false</code> into CG's constructor, and (after changes are applied) ETag won't get added to <code>$this->_headers</code>. What I haven’t considered in this article is Content-Encoding. Of course individual clients will only receive one encoding version (gzip or identity), hence the 304 response is unambiguous, but can proxy caches store two differently-encoded resources from the same URL and serve them correctly based on Accept-Encoding from the client? I just want to try out mod_cache/squid before I remove ETags from Minify.

I’d like to keep the CG class backward compatible. Minify::serve will pass in 'eTag' => false into CG’s constructor, and (after changes are applied) ETag won’t get added to $this->_headers.

]]> By: Tim http://mrclay.org/index.php/2009/03/03/you-probably-dont-need-etag/comment-page-1/#comment-102582 Tim Thu, 14 Jan 2010 03:18:44 +0000 http://mrclay.org/?p=274#comment-102582 So will this get updated into Minify? From what I could understand from looking over the ConditionalGet.php file, I fixed this by disabling two small bits of code. Comment out or remove line 146 and lines 288 to 293. I also swapped the checks on line 294 since the ETag would now be optional: <code>$isValid = ($this->resourceNotModified() || $this->resourceMatchedEtag());</code> This should remove extra ETag headers without (I assume) removing them when they should be there. So will this get updated into Minify?

From what I could understand from looking over the ConditionalGet.php file, I fixed this by disabling two small bits of code.

Comment out or remove line 146 and lines 288 to 293. I also swapped the checks on line 294 since the ETag would now be optional: $isValid = ($this->resourceNotModified() || $this->resourceMatchedEtag());

This should remove extra ETag headers without (I assume) removing them when they should be there.

]]>